diff --git a/libIRDB/include/core/scoop.hpp b/libIRDB/include/core/scoop.hpp index 160fc3150ed892bdee94f0ab77e32c39f40da527..b8f5b004eb5794e2a798b07b65fc654162626c4c 100644 --- a/libIRDB/include/core/scoop.hpp +++ b/libIRDB/include/core/scoop.hpp @@ -67,7 +67,7 @@ class DataScoop_t : public BaseObj_t bool isWriteable() const { return (permissions & permissions_w) == permissions_w; }; bool isExecuteable() const { return (permissions & permissions_x) == permissions_x; }; int getRawPerms() const { return permissions; } - int setRawPerms(int newperms) { permissions=newperms; } + void setRawPerms(int newperms) { permissions=newperms; } void SetName(const std::string &n) { name=n; } void SetContents(const std::string &n) { contents=n; } diff --git a/libIRDB/test/fill_in_cfg.cpp b/libIRDB/test/fill_in_cfg.cpp index 897d43de09a20a9a198879227f0ad70e174cb9a8..27fe45b696b63bf922633ef3a9ca10e4a5f728b8 100644 --- a/libIRDB/test/fill_in_cfg.cpp +++ b/libIRDB/test/fill_in_cfg.cpp @@ -445,13 +445,13 @@ void fill_in_scoops(FileIR_t *firp) fout<<"Found that section "<<elfiop->sections[secndx]->get_name()<<" is both writeable and executable. Program is inherently unsafe!"<<endl; } -#if 0 - /* executable sections handled by other bits. */ + /* executable sections handled by zipr/spri. */ if(elfiop->sections[secndx]->isExecutable()) { cout<<"Skipping scoop for section (executable) "<<elfiop->sections[secndx]->get_name()<<endl; continue; } +#if 0 // we decided to skip BSS for a bad reason. trying again. if(elfiop->sections[secndx]->isBSS()) { diff --git a/libIRDB/test/fill_in_indtargs.cpp b/libIRDB/test/fill_in_indtargs.cpp index 037fe40646ec969b60fc6c76a5506d53b471065a..2a89156253f470c94be8c37f4ae7523afe06474c 100644 --- a/libIRDB/test/fill_in_indtargs.cpp +++ b/libIRDB/test/fill_in_indtargs.cpp @@ -323,7 +323,7 @@ bool IsParameterWrite(FileIR_t *firp,Instruction_t* insn, string& output_dst) if(k < insn->GetFunction()->GetOutArgsRegionSize()) { - output_dst=d.Argument1.ArgMnemonic; + output_dst=string("[")+d.Argument1.ArgMnemonic+string("]"); return true; }