test_cmds.sh reports success when "fail" config results in test failing

Former-commit-id: 9eae8049ff18e10db709ee87b8dad3ee8f0b912d

cicd_tests/verify-fails.sh

@@ -8,21 +8,9 @@ source set_env_vars
 cd $PEASOUP_HOME/tests
 make clean
 
-# these tests must fail
-
-# verify ls failure
+# verify "fail" configuration
 ./test_cmds.sh -l -c fail -a ls
-if [ $? -eq 0 ]; then
-	echo "Error: expected ls failure"
-	exit 1
-fi
-
-# verify grep failure
 ./test_cmds.sh -l -c fail -a grep
-if [ $? -eq 0 ]; then
-	echo "Error: expected grep failure"
-	exit 1
-fi
 
 exit 0
 

tests/test_cmds.sh

@@ -218,7 +218,9 @@ do_tests()
 	done
 
 	if [[ $progs_fail != "" ]] || [[ $progs_fail_peasoup != "" ]]; then
-		had_fails=1
+		if [[ $config != "fail" ]]; then
+			had_fails=1
+		fi
 	fi
 }