Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Z
Zipr Toolchain
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Open Source Software
Zipr Toolchain
Commits
7e4ba22d
Commit
7e4ba22d
authored
6 years ago
by
Jason Hiser
Browse files
Options
Downloads
Patches
Plain Diff
change to support thanos exit messages if arg parsing fails
Former-commit-id: f11960b6e74fb2521f47ead4c222f39dc64fb923
parent
965182ac
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
tools/thanos/thanos.cpp
+12
-2
12 additions, 2 deletions
tools/thanos/thanos.cpp
with
12 additions
and
2 deletions
tools/thanos/thanos.cpp
+
12
−
2
View file @
7e4ba22d
...
...
@@ -121,7 +121,7 @@ int main(int argc, char* argv[])
thanos_log
<<
"A critical step failed: "
<<
plugin
->
getStepName
()
<<
endl
;
thanos_log
<<
"If DEBUG_STEPS is not on, this failure could "
<<
"be due to an earlier critical step."
<<
endl
;
return
1
;
// critical step failed, abort
return
2
;
// critical step failed, abort
}
}
// write back final changes
...
...
@@ -132,7 +132,7 @@ int main(int argc, char* argv[])
<<
endl
;
thanos_log
<<
"If DEBUG_STEPS is not on, this failure could "
<<
"be due to an earlier critical step."
<<
endl
;
return
1
;
// critical step failed, abort
return
2
;
// critical step failed, abort
}
else
{
...
...
@@ -299,6 +299,16 @@ int ThanosPlugin_t::executeStep(TransformStep_t& the_step, const bool are_debugg
const
int
parse_retval
=
the_step
.
parseArgs
(
step_args
);
if
(
parse_retval
!=
0
)
{
if
(
step_optional
)
{
*
real_cout
<<
"Done. Command failed! ***************************************"
<<
endl
;
}
else
{
*
real_cout
<<
"Done. Command failed! ***************************************"
<<
endl
;
*
real_cout
<<
"ERROR: The "
<<
the_step
.
getStepName
()
<<
" step is necessary, but failed. Exiting early."
<<
endl
;
}
return
parse_retval
;
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment